ZenphotoCMS Forum
RFC - Requirements when posting comments - Printable Version

+- ZenphotoCMS Forum (https://forum.zenphoto.org)
+-- Forum: Support (https://forum.zenphoto.org/forum-1.html)
+--- Forum: General support (https://forum.zenphoto.org/forum-4.html)
+--- Thread: RFC - Requirements when posting comments (/thread-3550.html)



RFC - Requirements when posting comments - oscar - 2008-08-24

In functions-controller.php function zp_handle_comment(), it checks for:

[isset($_POST['name']) && isset($_POST['email']) && isset($_POST['comment']))

However, right after that, it checks if these exists again, and if not, assigns "". What is the reasoning behind this? This means that even if I don't require e-mail, I can't remove it from the theme.

Should be safe to remove the first check altogether, no?




RFC - Requirements when posting comments - sbillard - 2008-08-24

The checks seem out of place. You should be able to remove them. The required fields tests should be enough.




RFC - Requirements when posting comments - oscar - 2008-08-25

Great, thanks. Will you get this into trunk as well? I'm sure I will forget why comments aren't working for 1.3 otherwise




RFC - Requirements when posting comments - sbillard - 2008-08-25

Done