Nice update. Wish this could become the trunk somehow. I had one fix that did not make it:
A fix for missing album thumbs breaking HTML code:
template-functions.php COMPARISON
Produced: 8/18/2007 1:07:29 PM
Mode: Differences with Context
Left file: C:\Junk\zenphoto\zen\class-album.php
Right file: O:\Copy of WEB Photo Album\htdocs\zen\class-album.php
L266=R266 function getAlbumThumb() {
$image = $this->getAlbumThumbImage();
if (!is_null($image)) {
return $image->getThumb();
} else {
L271 return null;
R271 return "/zen/images/err-imagenotfound.gif";
L272=R272 }
}
Hi aitf311
Seems I only get a blank index page with your version of zenphoto. The admin interface works, but the actual gallery just comes up white, no content whatsoever and no errors anywhere. I don't get what's wrong. A default zenphoto install works fine for me.
A friend installed it about 4 hours ago (i don't think you updated it since then) and got this error:
Fatal error: Cannot redeclare show_album_menu() (previously declared in /mnt/w0202/d35/s43/b02a877a/www/sorinc.net/zenphoto/zen/template-functions.php:940) in /mnt/w0202/d35/s43/b02a877a/www/sorinc.net/zenphoto/zen/functions-albums.php on line 215
Maybe that helps?
Looks like the show_album_menu() function got inserted in both the template-functions and the functions-album files. Just delete one of the copies and things should be better. At some point all the functions-albums code should end up in template functions (and the subalbum paging routines should be integrated into the original code from which they were lifted.) If only we had the ability to manage the SVN while Tris is out of circulation we could make permanant changes!)
Why don't you folks still working on zenphoto fork it, set up your own SVN repo and keep that up to date? Or maybe you could use git. Anyway, if/when tris is able to work on zenphoto again, it should not be too big a hassle to reintegrate the branches.
edit: btw removing one of the function's definitions worked. I now have a functional zenphoto install.
@acrylian: Are you using atif311's build? If so then subalbum sorting is implemented. You have to manually set the subalbum order through something like the phpMyAdmin interface. If you don't, the order should be newest first. If you are not using that build, then the order is the way they are on disk. I suggest you use the build rather than hack the order. That way you won't have to adapt the code in the future.
@sbillard: Yes, thanks, I know that but the menu was made with users in mind who don not want/can this or simply use the official version.(which is I am testing with). It should work sort of "out of the box" with the official release first...:-)
If you look at the current code of the menu you'll see that I query all albums and subalbums with one db query by sort_order. That gets the subalbums listed reversed. I now simply do two different db queries for albums by sort_order and for subalbums by id. Now everything is right. Certainly I could do another query first to check if there is a sort_order or not (like I had with the image_counter) but I think the less queries the better...I post the code of the new version soon then you can take a look at.
And a little adapting for an (official) future version would be not that problem.
I have updated the package to remove the double function that was in the previous version and also:
acrylian's comment rss page here: http://www.zenphoto.org/support/topic.php?id=1678&replies=1#post-9528
zenvideo fix here: http://www.zenphoto.org/support/topic.php?id=795&page=3&replies=83#post-9533
Frank: I would implement it into this package but it looks like it would force everyone else using that theme to use the password protection also. Under the current implementation of password protection a new theme would need to be developed, which is something I might put in this package.
Skee: that is a great idea, would definitely save me some headaches. I just had high hopes for Tris but it looks like he is all together too busy to even setup access to the current SVN.
@aitf311-
Looks like Tristan is back with some good things for development, so you may get your wish soon to have these code updates in the SVN.
Hi there,
I downloaded the package and the google mapping is not working correctly. It seems to be on some photos (example : http://desbureaux.ovh.org/Andalousie_2007/index.php?album=02+-+Jerez+et+Cadiz&image=PICT0077.jpg)
it seems to be a problem of ascii (look at the reference of latitude and longitude, it's a mess). On some other photos (of the same camera, same journey, same geotagging...) it doesn't appear (example : http://desbureaux.ovh.org/Andalousie_2007/index.php?album=09+-+Sierra+Nevada&image=PICT0400.jpg)
any idea to fix the EXIF ?
Ok, I kind of fix it putting a function giving only the first character of the reference in template-functions.php:
`if($exif['EXIFGPSLatitudeRef'] == 'S'){ $lat = '-' . $lat; }
if($exif['EXIFGPSLongitudeRef'] == 'W'){ $long = '-' . $long; }`
replaced by:
`if(substr($exif['EXIFGPSLatitudeRef'],0,1) == 'S'){ $lat = '-' . $lat; }
if(substr($exif['EXIFGPSLongitudeRef'],0,1) == 'W'){ $long = '-' . $long; }`
@ait311:
Since Zenphoto development seems to be back on track, I have integrated the subalbum support functions into the mainline code. (I haven't posted it anywhere yet!) So, if you go anywhere with your build we will have to delete the code you copied from my Subalbum-Functions.php file.
@sdesbure
Hmm. There must be a problem parsing the correct EXIF Lat/Long Ref. Either it is corrupted/incorrect or the library needs hacking again.
I took a look at the image with a exif plugin I have for Firefox and it has trouble reading the GPS EXIF data as well (it doesn't display it).
I'll try to look at the image in another program when I get home.