Member
Member
edbury   01-03-2008, 23:34
#1

Tags, when clicked, will return a search result of t+ag not "t ag."

While this default makes sense to me in the context of the search form, it seems that clicking that tag "middle sized dry good" should return the results for "middle sized dry good" not middle+sized+dry+good.

Any quick fix for this?

[I realize I could simple use no spaces in tags, but where's the fun in that?]

Member
Member
sbillard   02-03-2008, 02:11
#2

Is it the URL you are complaining about?

Member
Member
edbury   02-03-2008, 05:39
#3

The results.

A search for "photo gallery" and photo+gallery will return different things, as expected. If you click on a tag, it returns the results for photo+gallery - so any thing with tags that use "photo" or "gallery" will show up, not just those tagged "photo gallery."

I see what you mean about the url though. If you change the url in the browser to

/page/search/tags/"photo gallery"

from

/page/search/tags/photo+gallery

you get the desired result.

It just seems to me that this should be the default functionality.

Member
Member
edbury   02-03-2008, 09:50
#4

As an addendum, since I don't expect y'all to get up and change everything around based on one point of view:

Is there a simple to get things working this way? Also, any way to have tags separated by ", " instead of "," ? (The second, I realize, it's a purely personal convention).

Administrator
Administrator
acrylian   02-03-2008, 10:16
#5

I would agree that the quotes around tags when clicking on a tag probably should be by default.

For "," vs ", ", which would be of course typographically correct, this separator is an option of printTags():
http://www.zenphoto.org/documentation/zenphoto/_template-functions.php.html#functionprintTags

Member
Member
sbillard   02-03-2008, 19:33
#6

There is a bug in the TAGS links for tags with special characters in them. They should have been quoted in the link. The link itself is URL encoded (needs to be so that the URL is not broken.) That changes the spaces to plus signs. They will be changed back before applying the tag to the search, though.

The probelm is that since the tag was not quoted, when it was processed for the search, each word was treated as a search targed (they were ORed.) We wil get this corrected shortly.

Member
Member
sbillard   02-03-2008, 20:42
#7

The fix will be in tonight's nightly build.

Member
Member
sbillard   02-03-2008, 23:53
#8

Where is it that the tags are separated by ","? The printTags() function allows you to specify the separator, but it defaults to ", ".

Member
Member
edbury   03-03-2008, 01:29
#9

if the tag set is:

john smith, giulia

clicking john smith results in

/page/search/tags/john+smith

clicking giulia results in

/page/search/tags/+giulia

It's not a problem with the current setup, but after tonight's nightly build clicking on links with giulia as the first tag would give you different results than clicking on links with giulia as a following tag: "giulia" vs " giulia"

This could be a problem with my own setup, but I'm fairly sure I'm running from 1.1.5 standard.

Member
Member
sbillard   03-03-2008, 02:04
#10

This is also a but, It will be fixed in the nightly.

Member
Member
edbury   03-03-2008, 08:41
#11

running nightly - works like a dream so far. thanks so much for the quick attention.

  
Powered By MyBB, © 2002-2026 MyBB Group.
Made with by Curves UI.