division by zero error in exif.php in 1.1.6

Member

firsttimeuser 2008-05-30, 13:11

i guess this may be due to some faulty exif data in the image (exposure time?),

the line err'ing was 370, so on line 370, in version 1.1.6, so i just muted the error:

from
if (($bottom % $top) == 0) {

to
if (@($bottom % $top) == 0) {

is this sensible?

Member

firsttimeuser 2008-05-30, 13:19

line 371 was err'ing as well, so i added a check for zero to the code:

    } else if (&#36;tag == '829a') { // Exposure Time
        if (&#36;top == 0){
            &#36;data = 'Unknown';
        }
        else if ((&#36;bottom % &#36;top) == 0) {...

anyway, there's a lot of if / elseif's there for the tags, wouldn't a switch be neater?