you can email me at thinkdreams@gmail.com. sorry. i've been incommunicado for a bit. work has been very busy.

Well, first, here's what I used.

http://blog.feedmarker.com/2006/02/12/how-to-make-better-modal-windows-with-lightbox/

Second, keep an eye out in your inbox for my zip archive of the relevant files.

Sorry it took me so long.

Hey guys, sorry I've been away for so long... starting a company and all...

If you want to submit diffs the best way is to open up a new enhancement issue on Trac and attach them. I like to keep everything there, and I'll be notified when you do it and will be sure to integrate your changes.

I love that Google map on the image page. Very cool.

thinkdreams and mannkind,

this stuff is great, exactly what I'm looking to implement in a current project.

any progress getting your diffs accepted?

thanks!

@dspnorman-

EXIF is a great addition to zenphoto. However, Tris is currently the only one with commit access to SVN. We are working on the possibility of additional SVN commit privileges from him, but he is very busy with his new endeavor.

Where it stand right now, I have completed the ability for zenphoto to display EXIF tags from within the EXIF library built into zenphoto. Tris was starting the method by which the tags could then be written to the database for each image, thereby "caching" the information for each image in the DB instead of calling it from the image each time. However, since he has been quite busy, development on this has stalled. Without these methods, EXIF still works, but isn't fully integrated into the DB. I have a working concept on my site (http://www.bushwoodworking.com/zenphoto) using the latest SVN code, but haven't gone any further than that.

And that's where we're at today. I'd be happy to share everything I have to this point.

Cool, thanks.

I just found the mannkind's ticket with a diff to add google map location support with gps exif, which I'll definitely be making use of. I'm very new to subversion, though, so I'm not quite sure how to merge this in with my installed trunk.

thinkdreams, is the EXIF display on your site using the functions in r441 (trunk/zen/exif/), or do you have a lot of customized stuff?

I don't need to use the lightbox style display, but if your implementation offers other benefits to the current trunk, I'd be very interested in learning how to incorporate it.

thanks!

@mannkind-

I'm trying to use your patch from ticket #78, but I'm not sure how to run the patch command.

I'm running SVN r441, and put trunk.zen.diff in the root folder, then ran: patch -p1 < trunk.zen.diff, but get this:
`[~/zenphoto/trunk]# patch -p1 < trunk.zen.diff

can't find file to patch at input line 5

Perhaps you used the wrong -p or --strip option?

The text leading up to this was:

---

|Index: themes/testing/album.php

|===================================================================

|--- themes/testing/album.php (revision 441)

|+++ themes/testing/album.php (working copy)

---

File to patch:`

I know I'm doing something wrong, just don't know what!

My EXIF stuff is completely stock using the newer EXIF libraries that Tris helped me get set up just before he went AWOL. The EXIF stuff I'm using now is coded within the Zenphoto library system rather than being a hack, although it still only displays and doesn't include any database caching or image rotation functionality, which we had always talked about coming later.

The SVN is complete enough to display EXIF tags just fine (the lightbox functions are theme based and just something I came up with to display the EXIF tags in a non-intrusive manner). The function `` is what you'll want to refer to to obtain the tags in your theme. You can find it in the template-functions.php file for more detail.

Looking at the 441 SVN revision however, it looks like the printImageMetadata function replaces the printImageEXIFdata. I am not on the latest revision, so I may have to remedy that at some point so we're all comparing apples to apples.

Shouldn't change much though on the display side of things. Let me know how I can help further.

Thanks thinkdreams. I'm slowly getting the hang of the template stuff.

If you know where I'm going wrong trying to apply that patch, I'd appreciate any insight.

That's the trouble. I'm no good at patching SVN. Never actually have done it before. I've always relied on the developers of software to make the code mods rather than applying diffs.

Hmmm.

Ha, found the problem.

I was using the flag -p1, when I should have been using -p0. Basically, this controls how file names in the patch are mapped to your local SVN structure.

All is well, trunk successfully patched.

OK. Looking a bit more at the code, I updated my gallery to 441 (everything went fine). However, I had to add the old print function back in, as the imagemetadata function that replaced it didn't work properly. Something screwy with the javascript toggle function, which looks like "hides" the EXIF data from view until you click on the link. It errored out in Firefox. Might be something to take a peek at yourself if you have time.

So my current rev is 441, but I added the old function back in again for now.

Yeah, I saw that toggle function wasn't working, not sure why at the moment, but I will definitely take a look there to see what's going on.

EDIT: the header of the document specifys a script at /zen/scripts-common.js, but no file exists by that name. Presumably the toggle function would be defined in this file.

Is this something that was inadvertently left out of the current revision?

Beware, after applying the patch mentioned above, my zenphoto install is throwing a fatal error. It looks like part of the mapping code didn't get included.

I'm sure it's something I overlooked. Anyone know if the source for phooglelite.php is posted somewhere?

Re: the scripts-common.js. I saw that too. Probably an omission in the SVN code. I'm still trying to find where in the header that scripts-common.js is inserted in the code. Searching for scripts-common in the code pulled no results.

In fact, that scripts-common.js is in all the theme pages. Strange.

Found it. template-functions.php at the top. References:

`/**

• Print any Javascript required by zenphoto. Every theme should include this somewhere in its .

*/

function zenJavascript() {

if (zp_loggedin()) {

echo "  n";

echo "  n";

sajax_show_javascript();

echo "  ";

}

echo " n";

}`

I'm going to remove the entry for now in my template-functions.php file so it works without errors. But that's why. I couldn't find the scripts-common.js in any of the older versions so it must have been something that was created but not tested or uploaded.

I'll go ahead and mark this as a bug in the trac system so we can keep an eye on it.

I just hacked up a quick toggle function, and attached it to your bug ticket.

Put the file in /zen/scripts-common.js and then re-enable that entry in your template functions, and the EXIF toggle should work just fine. You may have to switch back to the newer printImageMetadata function as well.