Give the nightly build a try after tonight. I did change the code to make it (what I think is) correct. However I can't see the problems (nor the difference with the new code) that you have, so it needs some more testing.

thanks sbilliard for looking into this.
I am not trying to make a point here, as I said it is solved for myself so I am fine. I am just trying to help making ZP better.
I am not sure I understand you saying that the code change has no effect?
So when you create a cropped thumb out of a landscape image you do not get the zoom?
Have you had a look at the log file?
At the moment the min() function multiplies the image height with the crop ratio to calculate the crop width. $cw.

Btw I also would like to mention that most thumbs look better when $cy is calculated to be off center towards the top just like when mounting real pictures.
line 282 ....divide by 3 instead of 2...
This has to do with the law of thirds. A basic design principle most photos follow.

What I was saying is that I have not seen the "zoom" that you did. Not sure why, but in my testing I don't see a difference between the "correct" code and the wrong code. Thus I am not sure if the problem is really fixed.

Your suggestion to use the law of thirds is a good one. Hopefully no one will object to the change in behavior.

ok, I see. I have done the calculations manually and have added them to the log file at the bottom : http://www.bregler.net/backup/log.txt
for both an 500x336 and an 233x336 crop calculation to come by a 200x113 tumb
Maybe that helps you to repeat the issue I had

I have change the $cy in my custom function to "/3" and I think it looks a lot better.
So for everybody who is not familiar with the law of thirds here is some reading:
http://www.silverlight.co.uk/tutorials/compose_expose/thirds.html
A lecturer of mine used to say that you can break every rule if you know them and know why; I am sure there is plenty of exceptions which are still great pictures but especially in framing and mounting it is almost certainly used:
http://en.wikipedia.org/wiki/Headroom_%28photographic_framing%29
I would vote for this go into the next release

I guess I just had "well behaved" images. Both portrait and landscape came out well. Anyway, give the nightly build a try and report back. (Tonight's will have the rule of thirds change.)