Member
Member
fatman   22-06-2011, 00:59
#1

I found the speed to access album edit page is quite slow, after checking the code, the gallery->garbageCollect() take about 40s to run, if for a save operation, it load twice, so it will take double time.

The problem is it fetch all row in 'obj_to_tag' and loop to check each object exist in corresponding table or not. As a result, my gallery need to run above 10000 query for this the check.

I think it is quite easy to rewrite it in delete sub query. such as
DELETE FROM obj_to_tag WHERE type = 'album' and objectid not in (SELECT id FROM albums)

Maybe store different object types in option/constant if don't want to hardcode in program, or even SELECT DISTINCT type FROM obj_to_tag can do it(but not a good practice)

BTW, I just update to 1.4.1, the version.php got a extra empty line at beginning.

Administrator
Administrator
acrylian   22-06-2011, 07:55
#2

Please open a ticket.

Member
Member
fatman   22-06-2011, 13:59
#3

No password reset page on Trac?

Administrator
Administrator
acrylian   22-06-2011, 15:29
#4

I fear not... at least I don't know it I admit... We could delete your account and you re-register...

Member
Member
fatman   22-06-2011, 15:40
#5

OK...

(I believe my password on forum & trac is the same, strange that can't login trac)

Administrator
Administrator
acrylian   23-06-2011, 08:46
#6

So shall we delete your account then?

Member
Member
fatman   23-06-2011, 08:53
#7

OK to delete...

  
Powered By MyBB, © 2002-2026 MyBB Group.
Made with by Curves UI.