Home› General support

Admin pages not showing nesting

Blue Dragonfly Member
in General support
For the last few days, the nightly builds seem to have stopped showing nesting in the admin Pages tab. The nesting data is preserved - sub-pages are nested properly in the Pages menu. But when trying to drag them around, I get the "no can do" mouse pointer.

I also see some JavaScript errors in the Firefox error console, the one that is an error and not just a warning is:

`
Error: $("#left-to-right").NestedSortable is not a function
Source File: zp-core/zp-extensions/zenpage/admin-pages.php
Line: 553
`
Is this just me? I figured if it was a bug in the nightlies, someone would have noticed and corrected it by now, since surely the developers use every single feature to it's full extent, and thoroughly test each one every single day :-)

Comments

  • sbillard Member
    Well, it is really hard for us to use EVERY feature in EVERY in every way. There is just too much there. We do rely on reports like yours to tell us if there is something we have missed.

    However, in this case I do not see the problem. Not in Firefox, not in IE. Did you by any chance upgrade your version of jQuery or jQueryUI? We know that the jQuery 1.4.2 version breaks the sorting.
  • kagutsuchi Member
    I can reproduce this with the latest trunk, verified using JQuery 1.4.1. I get the same error in Firefox's error console as well.

    `
    Error: $("#left-to-right").NestedSortable is not a function
    Source File: zp-core/zp-extensions/zenpage/admin-pages.php
    Line: 247
    `
    Different line number for me, however.
  • Blue Dragonfly Member
    sbillard - Oh, I couldn't expect EVERYthing to be tested in the nightlies - but, the forum doesn't have sarcasm tags to wrap blocks of text in, so I rely on people's own good sense to pick it up :-)

    I reverted from 1.4.2 to 1.4.1 shortly after the 1.2.9 upgrade per the news item, and I just verified that I am still using 1.4.1.

    kagutsuchi - thanks, I'm glad it's not just me! Those are the hardest ones to figure out :-) I think all my source files are in sync (I'm pretty sure I'm not using yesterday's nightlies with some patches from today). If there's anything you want me to try out on this end, just let me know.
  • sbillard Member
    It would be good if the two of you could compare configurations, plugins, etc. Maybe there is a javascript conflict somewhere.

    As to changes recently that might impact this, the only suspicious one would be the change that made browser comments/cdata brackets around the javascript. Perhaps you can judiciously look at those changes with regard to the album sorting.
  • Blue Dragonfly Member
    I saw the changes that encased the scripts in CDATA blocks, and that may be related. I'll try to undo those changes and see if it makes a difference.

    Did you want kagutsuchi and I to compare configurations, or us to compare to the trunk?
  • sbillard Member
    You and kagutschi to see what is similar.

    But I have a new wrinkle. I am seeing this problem on the zenpage pages tab (but still not on the albums tab.)
  • kagutsuchi Member
    My server's installation is completely vanilla (besides the Imagick lib). I've just reverted to revision 5241 and it now works. I think it's a problem from the CDATA changeset 5242.

    Edit: reverted to revision 5242 and it doesn't work again. Must be that changeset.
  • Blue Dragonfly Member
    I noticed that also, and am looking to see why Albums are unaffected but Pages are. Looking for the function in the page source, I noticed that the following is printed in the header on the admin-edit page, but not othen admin-pages page - this might be a clue:

    `





    `
  • kagutsuchi Member
    That does seem to be the problem, Blue Dragonfly. See here: http://www.zenphoto.org/trac/changeset/5242/#file45

    If you add those first three lines back that were taken out, it works again.
  • sbillard Member
    I have found and fixed the pages problem. It cannot be the same as causing you problems with albums.
  • Blue Dragonfly Member
    Yep, just found that difference and tested it here, too - and it works fine now.

    sbilliard - I was not having any problem with Album nesting, only with Pages nesting. So after adding those three lines back in, it all seems to be working fine on my end.
  • acrylian Administrator, Developer
    Weird, I really don't know why these lines would have dissapeared. These were there from the beginning of Zenpage...:-)
  • sbillard Member
    Well, they dissappeared because they were not doing anything. There was a change to move those js files. I guess that these lines did not get updated at that time. Anyway, they were throwing 404 errors because they were loading non-existant js files. I just presumed that they were redundant as normally the javascript gets loaded by the admin functions. Guess that Zenpage decided to be different here.

    Anyway, the nightly puts the correct version of those lines back in.
  • acrylian Administrator, Developer
    Well, Zenpage was first separatly release and had these from the beginning. Might be an oversite when we adapted the Zenpage sorting stuff to the album sorting as well.
Sign In or Register to comment.