Member
Member
oscar   2008-08-24, 16:01
#1

In functions-controller.php function zp_handle_comment(), it checks for:

[isset($_POST['name']) && isset($_POST['email']) && isset($_POST['comment']))

However, right after that, it checks if these exists again, and if not, assigns "". What is the reasoning behind this? This means that even if I don't require e-mail, I can't remove it from the theme.

Should be safe to remove the first check altogether, no?

Member
Member
sbillard   2008-08-24, 17:54
#2

The checks seem out of place. You should be able to remove them. The required fields tests should be enough.

Member
Member
oscar   2008-08-25, 06:45
#3

Great, thanks. Will you get this into trunk as well? I'm sure I will forget why comments aren't working for 1.3 otherwise

Member
Member
sbillard   2008-08-25, 17:23
#4

Done

  
Powered By MyBB, © 2002-2026 MyBB Group.
Made with by Curves UI.