Administrator
Member
bummer... those functions in 1.2.2 are still broken. 
any chance somebody could insert the algorithm i've provided above into the functions? I think it would be a quick fix since it seems like the problem is that they simply aren't calculating the size correctly.
looks like it might all be calculated in getMaxSpaceContainer, but that function seems to be written in a much more convoluted manner than necessary (imho). unfortunately, that function seems to be using some php concepts that I don't yet understand (e.g., &$width).
any chance somebody could insert the algorithm i've provided above into the functions? I think it would be a quick fix since it seems like the problem is that they simply aren't calculating the size correctly.
looks like it might all be calculated in getMaxSpaceContainer, but that function seems to be written in a much more convoluted manner than necessary (imho). unfortunately, that function seems to be using some php concepts that I don't yet understand (e.g., &$width).
Member
Um... no... 'cause acrylian said there's nothing new in the nightly build. but I'll try it now and post back if it still doesn't work. thanks!
Administrator
Member
well... it is much closer to working now, but it is still buggy. so far, i've discovered the following problems:
-passing NULL for width produces unexpected results (what SHOULD happen is the the image just gets constrained via the height variable)
-strangely, the following two calls do NOT produce the same results:
1. printCustomSizedImageMaxSpace('', $width, $height, null, null, true);
2. printCustomSizedImageThumbMaxSpace('', $width, $height);
the first one stretches the image incorrectly; the second one seems to work (I haven't looked at the new code, but in a previous version one of these functions just called the other, so it seems strange that these two calls produce different results)
Hope this helps...
-passing NULL for width produces unexpected results (what SHOULD happen is the the image just gets constrained via the height variable)
-strangely, the following two calls do NOT produce the same results:
1. printCustomSizedImageMaxSpace('', $width, $height, null, null, true);
2. printCustomSizedImageThumbMaxSpace('', $width, $height);
the first one stretches the image incorrectly; the second one seems to work (I haven't looked at the new code, but in a previous version one of these functions just called the other, so it seems strange that these two calls produce different results)
Hope this helps...
Administrator
Regarding passing NULL for width: These functions are supposed to have always set width and height. That is what they are made for to fit into width x height without cropping. Leaving one out does not makes sense to me...
Hm regarding the stretching. I did really a lot test a few days ago and I didn't notice any stretching anymore. Did you purge the cache? Just to ask...
Hm regarding the stretching. I did really a lot test a few days ago and I didn't notice any stretching anymore. Did you purge the cache? Just to ask...
Member
Passing NULL for a width or height value is the same as passing 0. These functions requrire both parameters. If you want them to be the same value, pass the value as both the height and the width.
The only difference between the `printCustomSizedImageMaxSpace(0)` and `printCustomSizedImageThumbMaxSpace()` functions is how they handle the case of video images. `printCustomSizedImageThumbMaxSpace` will use the video thumbnail image. `printCustomSizedImageMaxSpace()` will use the configured flash plalyer so the function is effectively NULL.
The only difference between the `printCustomSizedImageMaxSpace(0)` and `printCustomSizedImageThumbMaxSpace()` functions is how they handle the case of video images. `printCustomSizedImageThumbMaxSpace` will use the video thumbnail image. `printCustomSizedImageMaxSpace()` will use the configured flash plalyer so the function is effectively NULL.