Pages (2):    1 2
Member
Member
sbillard   08-02-2011, 00:11
#21

Is this with the 1.4.0.2 release? If so you will most likely have some conflicting CSS. Be sure that the "container" where you wish to display your map is at least as big as the area needed to display the map. Otherwise it will not render correctly (know google map issue having nothing to do with zenphoto.)

BTW, did you not get updates from the ticket?

Member
Member
vincent3569   08-02-2011, 01:59
#22

In fact, I have migrated to 1.4.0.2.
Now googleMap plugin is going well and well displays my pictures (with correct zoom level)!

But I found a little bug :
I wrote this line `` to automatic display the map, without any text : but it doesn't work.

I read /zp-core/zp-extensions/GoogleMap.php :
lines 286 to 288 : there are a few lines of code that are unnecessary :
` if (empty($text)) {

    $hide = 'hide';

}

`
Are you OK with that ?

Member
Member
sbillard   08-02-2011, 02:37
#23

That should have read $hide='show'; If there is no text, there is nothing to click on to reveal the map.

Member
Member
vincent3569   08-02-2011, 08:20
#24

I don't want any text to reveal the map.
I want to always have the map displayed, if they are some localized pictures

accordind to me, the lines 286 to 288 are unnecessary : there is other code for hidding or not the map

Member
Member
vincent3569   13-02-2011, 21:14
#25

hi

I have installed the nightbuild (1.4.0.2 [6701]).
the problem is still the same :
with english language (and no european languages), pictures are displayed with a correct zoom level in googlemap.
with european languages (french, spanish, german, italian,...), the zoom level is incorrect.
sbillard, acrylian, I have activated dynamic-locale plugin : you could see the problem here : http://vincent.bourganel.free.fr/zenphoto_test2/index.php?album=neige

Member
Member
sbillard   13-02-2011, 22:41
#26

Sorry, your site behaves very badly. If I select another language, it takes me to the home page. But it does not remember the language, so I cannot get to the page with the map and be in anything but English.

Administrator
Administrator
acrylian   14-02-2011, 10:10
#27

Indeed, I am directed to the home page as well when selecting a language. The language is actually selected correctly.

But besides that I am able to see the issue with the automatic German language setting. I sent screenshots via mail to you, sbillard.

Member
Member
sbillard   14-02-2011, 19:10
#28

Is there some reason that you do not want to use the ticket system to persue this? Because if you don't do that the problem will NOT be solved.

Member
Member
vincent3569   14-02-2011, 23:51
#29

hi

I have reopened the ticket #1797, and added some screnshot.

Member
Member
vincent3569   21-02-2011, 22:04
#30

hi

I have tried the NightBuild [6763].
Now the googlemap plugin works fine : the map is displayed with correct zoom level, with all languages.

But I found another mistake :
on changeset [6684] http://www.zenphoto.org/trac/changeset/6684, you have added this code :
`

if (empty($text)) {

$hide = 'show';

}

`

it was OK for my pesonnal use (I want to always have the map displayed, with no text to reveal the map, if they are some localized pictures)

but now, you have this code :
`

301 if (empty($text)) {

302 $hide = 'show';

303 }

304 if (is_null($hide)) {

305 $hide = getOption('gmap_hide');

306 }

307 if ($hide) {

308 $hide = 'hide';

309 } else {

310 $hide = 'show';

311 }

312

313 if (!is_null($callback)) {

314 call_user_func($callback,$MAP_OBJECT);

315 }

316 if (empty($text)) {

317 $hide = 'hide';

318 }

`

it seems that lines 316-318 are redundant with lines 301-303 but the last ones are doing the wrong thing.

Member
Member
sbillard   22-02-2011, 00:16
#31

You are correct. This is one of the areas that is quite different in the Development build. The translation to the Support build was not correct. We will get it stratghtened out in tonight's build.

Member
Member
vincent3569   24-02-2011, 23:17
#32

thanks a lot !

now the plugin is working well for me and I have no other problems.

Pages (2):    1 2
  
Powered By MyBB, © 2002-2026 MyBB Group.
Made with by Curves UI.